Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expat: 2.4.5 -> 2.4.6 #161090

Merged
merged 1 commit into from
Feb 20, 2022
Merged

expat: 2.4.5 -> 2.4.6 #161090

merged 1 commit into from
Feb 20, 2022

Conversation

hartwork
Copy link
Contributor

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Thank you very much!

@SuperSandro2000 SuperSandro2000 merged commit 7a5b0fa into NixOS:staging Feb 20, 2022
@SuperSandro2000
Copy link
Member

@hartwork I still want to encourage you to add yourself as a maintainer to this package. You already did a lot in recent history and if you not always have the time there are other people who can jump in like they already did.

@vcunat
Copy link
Member

vcunat commented Feb 24, 2022

I see this regression: https://hydra.nixos.org/log/mf45kyxlsnlan090qbi4xs8s7bbgg4lc-python3.9-xmltodict-0.12.0.drv

I reproduce it locally. The package has no maintainers in NixPkgs.

@hartwork
Copy link
Contributor Author

I see this regression: https://hydra.nixos.org/log/mf45kyxlsnlan090qbi4xs8s7bbgg4lc-python3.9-xmltodict-0.12.0.drv

@vcunat thanks for bringing this to my attention. I have create a ticket with xmltodict upstream about the issue at martinblech/xmltodict#289 just now.

@vcunat
Copy link
Member

vcunat commented Mar 3, 2022

Another python package: https://hydra.nixos.org/log/lqmml3l0bx76q93z53glaajm1dqdkfjx-python3.9-jxmlease-1.0.3.drv

EDIT: I haven't looked into details of the failure, but I see no mention or fix upstream so far.

@hartwork
Copy link
Contributor Author

hartwork commented Mar 3, 2022

@vcunat thanks for bringing jxmlease to attention 👍

@hartwork
Copy link
Contributor Author

hartwork commented Mar 3, 2022

@vcunat
Copy link
Member

vcunat commented Mar 3, 2022

Uh, well the main complication I see is that expat changes are very expensive for NixPkgs.

@hartwork
Copy link
Contributor Author

hartwork commented Mar 3, 2022

@vcunat I didn't mean to suggest application of that pull request in NixPkgs prior to a release. My intention behind sharing that link was to highlight that a fix has been in the making upstream. But maybe I'm misreading your reply?

@vcunat
Copy link
Member

vcunat commented Mar 3, 2022

Release or not, the expense here will be the same. But maybe in the end that will be easier than fixing all the broken reverse dependencies, given that human time is scarce.

@vcunat
Copy link
Member

vcunat commented Mar 5, 2022

#162889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants