-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expat: 2.4.5 -> 2.4.6 #161090
expat: 2.4.5 -> 2.4.6 #161090
Conversation
Thank you very much! |
@hartwork I still want to encourage you to add yourself as a maintainer to this package. You already did a lot in recent history and if you not always have the time there are other people who can jump in like they already did. |
I see this regression: https://hydra.nixos.org/log/mf45kyxlsnlan090qbi4xs8s7bbgg4lc-python3.9-xmltodict-0.12.0.drv I reproduce it locally. The package has no maintainers in NixPkgs. |
@vcunat thanks for bringing this to my attention. I have create a ticket with xmltodict upstream about the issue at martinblech/xmltodict#289 just now. |
Another python package: https://hydra.nixos.org/log/lqmml3l0bx76q93z53glaajm1dqdkfjx-python3.9-jxmlease-1.0.3.drv EDIT: I haven't looked into details of the failure, but I see no mention or fix upstream so far. |
@vcunat thanks for bringing jxmlease to attention 👍 |
Uh, well the main complication I see is that expat changes are very expensive for NixPkgs. |
@vcunat I didn't mean to suggest application of that pull request in NixPkgs prior to a release. My intention behind sharing that link was to highlight that a fix has been in the making upstream. But maybe I'm misreading your reply? |
Release or not, the expense here will be the same. But maybe in the end that will be easier than fixing all the broken reverse dependencies, given that human time is scarce. |
Motivation for this change
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes