-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expat: 2.4.6 -> 2.4.7 #162889
expat: 2.4.6 -> 2.4.7 #162889
Conversation
This primarily fixes regressions in various other packages after the expat security fixes.
This reverts commit 0451c28. Now it's not needed anymore.
Oh and the revert in this PR... might better get adjusted? @jonringer: the |
On stable it's already being built. b80b398c16 |
If |
Well we could, but as |
No but it would give manual reviewers a hint that it might be worth checking that package. |
Feel free to push that change. In the meantime I've tested these changes on my local python-updates tree and it fixes a few regressions of the |
as it has revealed compatibility issues in the past
Can always decide to pick this up for staging-next, but I want this for python-updates now because the number of failing tests is annoying and us hotpatching everything is not going to happen. |
I suspect that this regression is related to expat updates, in case someone wanted to have a closer look: https://hydra.nixos.org/build/169724144 |
Motivation for this change
This primarily fixes regressions in various other packages after the expat security fixes.
I'm unsure if this should go to
staging-next
(current iteration) or the next one (staging
branch). It rebuilds stdenv on all platforms, but it also fixes some regressions from the expat security update. Note that the commits are based in a way to allow easy merging to either/both branches.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes