Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globe-cli: init at 0.2.0 #161239

Merged
merged 3 commits into from
Feb 21, 2022
Merged

globe-cli: init at 0.2.0 #161239

merged 3 commits into from
Feb 21, 2022

Conversation

devhell
Copy link
Contributor

@devhell devhell commented Feb 21, 2022

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Feb 21, 2022

Ups, that didn't do as intended...

@fabaff
Copy link
Member

fabaff commented Feb 21, 2022

Result of nixpkgs-review pr 161239 run on x86_64-linux 1

1 package built:
  • globe-cli

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.maintainers is set
  • package builds (see globe-cli: init at 0.2.0 #161239 (comment))
  • all depending packages build
  • tested on x86_64
...ew/pr-161239-1]$ ./results/globe-cli/bin/globe -h
globe-cli 0.2.0
adamsky <adamsky@enum.space>
Render an ASCII globe in your terminal.

USAGE:
    globe [FLAGS] [OPTIONS]
[...]

Looks good to me. TUI works.

@devhell
Copy link
Contributor Author

devhell commented Feb 21, 2022

@fabaff Is this okay to merge? Thanks for the review! 🍻

@SuperSandro2000 SuperSandro2000 merged commit 4faad70 into NixOS:master Feb 21, 2022
@devhell devhell deleted the init-globe-cli branch February 22, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants