labels: only add labels #164517
Closed
labels: only add labels #164517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather not use a workaround as if upstream breaks it we're right back were we started. Don't really want to pin the label action just to keep a workaround. |
|
Will this still remove outdated labels for files no longer included in the PR? |
|
Probably not. And so we ask ourselves, "which is more valuable:" Labeling these couple platforms based on title, or based on the path. cc @alyssais who proposed the ofborg PR. |
|
They'd prefer the title-based labeling for BSD, so I'll close this and just remove those paths from the label config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#164504 (comment)
cc @zowoq