Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maphosts: init at 1.1.1 #16594

Merged
merged 1 commit into from
Jul 2, 2016
Merged

maphosts: init at 1.1.1 #16594

merged 1 commit into from
Jul 2, 2016

Conversation

mpscholten
Copy link
Contributor

Motivation for this change

Adds the maphosts package.

Open question:

  • I was following the wiki page on how to bundle a ruby gem. The issue is that when installing the maphosts package, it will also provide a bundler binary. E.g. jekyll does the same. So when installing jekyll and maphosts you will have a conflict because both packages provide bundler. So how should this be handled? IMO no ruby package should provide the bundler binary by default.
  • Is it ok if I add myself as a maintainer of the package? Did not found any documentation on this :)
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @zimbatm, @edolstra and @peti to be potential reviewers

@joachifm joachifm merged commit 291c454 into NixOS:master Jul 2, 2016
@zimbatm
Copy link
Member

zimbatm commented Jul 2, 2016

@mpscholten one way to do it is wrap the buildEnv in another derivation to expose just the binary you want. See the cide package for example.

@mpscholten
Copy link
Contributor Author

@zimbatm thanks for pointing me in the right direction :) Just created a pr to implement this: #16676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants