Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.notifymuch: Init at 0.1 #166075

Merged
merged 2 commits into from Mar 29, 2022
Merged

python3Packages.notifymuch: Init at 0.1 #166075

merged 2 commits into from Mar 29, 2022

Conversation

arjan-s
Copy link
Contributor

@arjan-s arjan-s commented Mar 28, 2022

Description of changes

Add new package python3Packages.notifymuch. This is the code from the apparently abandoned PR #92797 but with the requested changes applied, adding myself as maintainer.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@arjan-s arjan-s mentioned this pull request Mar 28, 2022
Closed
10 tasks
SuperSandro2000
SuperSandro2000 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@SuperSandro2000 SuperSandro2000 merged commit 66cb200 into NixOS:master Mar 29, 2022
@arjan-s arjan-s deleted the init-notifymuch branch March 29, 2022 15:26
@arjan-s
Copy link
Contributor Author

arjan-s commented Mar 29, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arjan-s @SuperSandro2000 @Janik-Haag