-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.notifymuch: Init at 0.1 #92797
Conversation
d347391
to
cee8147
Compare
Reviewed points
Possible improvements
Commentslast commit was 5 years ago but it works. I ran it and I saw a notification with my unread messages. |
@glittershark friendly ping |
cee8147
to
5fd9e2e
Compare
@bbigras done. |
It's Linux only? I have no idea how notifications work on mac. |
I marked it linux only because I haven't tested it on mac. I can only assume that since it's very much tied to gobject/gtk libnotify this wouldn't work on mac, which uses its own notification thingy |
Gotcha. Thanks. |
/status needs_merge |
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
/status needs_merger |
The PR author cannot set the status to If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to |
preFixup = '' | ||
echo "wrapper args" | ||
echo "''${makeWrapperArgs[@]}" | ||
makeWrapperArgs+=("''${gappsWrapperArgs[@]}") | ||
echo "wrapper args again" | ||
echo "''${makeWrapperArgs[@]}" | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preFixup = '' | |
echo "wrapper args" | |
echo "''${makeWrapperArgs[@]}" | |
makeWrapperArgs+=("''${gappsWrapperArgs[@]}") | |
echo "wrapper args again" | |
echo "''${makeWrapperArgs[@]}" | |
''; | |
makeWrapperArgs = [ "''${gappsWrapperArgs[@]}" ] |
buildPythonApplication rec { | ||
pname = "notifymuch"; | ||
version = "0.1"; | ||
disabled = ! isPy3k; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled = ! isPy3k; | |
disabled = !isPy3k; |
@@ -0,0 +1,56 @@ | |||
{ stdenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not directly used
{ stdenv | |
{ lib |
|
||
strictDeps = false; | ||
|
||
meta = with stdenv.lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta = with stdenv.lib; { | |
meta = with lib; { |
/status awaiting_changes |
@glittershark friendly ping |
@glittershark friendly ping. Can we get this in the release please? |
yeah, I'll try to get to this in the next day or so. Been swamped with $dayjob |
/status awaiting_changes |
@glittershark ping |
I marked this as stale due to inactivity. → More info |
@glittershark ping |
You can also just create a new PR with the changes and we close this one. |
Okay, thanks for your answer. I've created a new PR here with the requested changes: #166075 |
Motivation for this change
I'd like to use the package
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)