Move some fixes from Gnome 3.18 to 3.20 #16747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienCassou
added
9.needs: reporter feedback
6.topic: GNOME
|
@DamienCassou, thanks for your PR! By analyzing the annotation information on this pull request, we identified @lethalman to be a potential reviewer |
DamienCassou
force-pushed
the
move-gnome3.18-to-3.20
branch
from
26266e2
to
f022d75
Compare
| , sqlite, libgweather, libcanberra_gtk3 | ||
| , libpulseaudio, libical, libtool, nss, gobjectIntrospection, gstreamer, makeWrapper | ||
| , accountsservice, gdk_pixbuf, gdm, upower, ibus, networkmanagerapplet, librsvg }: | ||
| , python3, python3Packages, libsoup, polkit, clutter, networkmanager |
There was a problem hiding this comment.
no need to have python3 and python3Packages since you can use python3Packages.python to obtain the interpreter. Furthermore, the interpreter is a runtime dependency of the Python packages.
DamienCassou
force-pushed
the
move-gnome3.18-to-3.20
branch
from
7b867e5
to
5f50020
Compare
The --with-ca-certificates flag seems to have been removed in [this commit][1] from March 2013. The configure script now just warns about an unknown option. [1]: https://git.gnome.org/browse/gnome-keyring/commit/?id=7afaae43f205c059163c3670169af302f1ba6de3
Without gnome3.gsettings_desktop_schemas and gnome3.evolution_data_server as buildInputs, gnome-maps won't start at all.
DamienCassou
force-pushed
the
move-gnome3.18-to-3.20
branch
from
5f50020
to
3c59cd8
Compare
DamienCassou
force-pushed
the
move-gnome3.18-to-3.20
branch
3 times, most recently
from
0f39a04
to
16396cd
Compare
DamienCassou
force-pushed
the
move-gnome3.18-to-3.20
branch
from
16396cd
to
0b5f4b3
Compare
DamienCassou
added a commit
to DamienCassou/nixpkgs
that referenced
this pull request
Jul 12, 2016
I changed from python3Packages to python2Packages because I couldn't make it work with python3Packages. This seems similar to: NixOS#16747 (comment)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix-shell -p nox --run "nox-review wip"./result/bin/)