photoprism: init at 220302-0059f429

[Misterio77]

Description of changes

Photoprism is a server-based application for browsing, organizing, and sharing your personal photo collection.

Most of this work was done by @newAM. I added aarch64 support and polished it up tiny bit.

I have an instance up and running on my RPi for a month now, and it's been working great.

Fixes #96043
Supersedes #99016

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[dotlambda]

Did you take package-lock.json directly from upstream? Can we turn generate-dependencies.sh into an update script that also downloads the newest package-lock.json?

[Misterio77]

Did you take package-lock.json directly from upstream? Can we turn generate-dependencies.sh into an update script that also downloads the newest package-lock.json?

Yup, that's right. _package-lock.json is taken from upstream. I can for sure make the script also download it.

Should I somehow make the script get the version from the .nix file, or is a version bash variable on the script itself enough?

[dotlambda]

Should I somehow make the script get the version from the .nix file, or is a version bash variable on the script itself enough?

It should either get the newest version from GitHub or use $1.

[dotlambda]

Can we put libtensorflow, backend, and frontend in separate files?

Also, did you consider using nodePackages? That's what I did for deltachat-desktop and it works the following way:

• package.json is downloaded and added to Nixpkgs
• that file is referenced in pkgs/development/node-packages/node-packages.json
• whenever pkgs/development/node-packages/generate.sh is run the dependencies for PhotoPrism are included in pkgs/development/node-packages/node-packages.nix
• in pkgs/development/node-packages/default.nix you have

photoprism = super."photoprism-../../servers/photoprism".override {
  meta.broken = true; # use the top-level package instead
};

• in pkgs/servers/photoprism/frontend.nix you use

nodejs-12_x.pkgs.photoprism.override {
  ...
}

The advantage is that it doesn't add as many lines of code to Nixpkgs, the disadvantage is that it doesn't respect package-lock.json.

[dotlambda]

Suggested change

	mkdir $out
	cp -r assets $out/
	install -Dt $out assets

though I'm not sure assets is the best directory name since it's very nonstandard, but it's okay for now.

[Misterio77]

We could instead use something more standard and change PHOTOPRISM_ASSETS_PATH.

[dotlambda]

Maybe share/photoprism?

[Misterio77]

Seems like a good one :)

[Misterio77]

Do we need to wrap to change the environment variable?

[dotlambda]

Yeah that should work.
What's the default value for this environment variable, i.e. why did $out/assets work?

[dotlambda]

Where are these used? Do we need to put them in $PATH using makeWrapper instead?

[Misterio77]

Those are all runtime deps. Should we make a wrapper instead?

[dotlambda]

Yes, I don't see how buildInputs would work.

[dotlambda]

Sorry for the wall of nitpicky comments!

[Misterio77]

Sorry for the wall of nitpicky comments!

No problem at all! Thanks a lot for the very helpful comments :)

[Stunkymonkey]

any chance this will get merged before 22.11 release? I would really like to have it available, but I am currently short on time.

[Misterio77]

Hey, I ended up not using photoprism a lot so this PR is a little stale (but should still work!). Feel free to take it over if you're interested!

[NickCao]

superseded by #199674