photoprism: init at 221102-905925b4d #199674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stunkymonkey
requested review from
dotlambda,
newAM,
Misterio77 and
thiagokokada
thiagokokada
requested changes
Nov 6, 2022
thiagokokada
reviewed
Nov 6, 2022
|
Result of 3 packages marked as broken and skipped:
6 packages failed to build:
65 packages built:
|
|
Result of 2 packages marked as broken and skipped:
3 packages failed to build:
68 packages built:
|
thiagokokada
approved these changes
Nov 6, 2022
13 tasks
andir
reviewed
Nov 19, 2022
| runHook postInstall | ||
| ''; | ||
|
|
||
| passthru.tests.photoprism = nixosTests.photoprism; |
There was a problem hiding this comment.
I think you forgot to add this test.
There was a problem hiding this comment.
Oh, you are correct. Guess this is a leftover from the previous PRs with an attached nixos module.
Thanks you! I'll fix that :)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Photoprism is a server-based application for browsing, organizing, and sharing your personal photo collection.
Most of this work was done by @Misterio77 and @newAM. I fixed the issues introduced by 7757aef that rendered the derivation unbuildable for me.
In addition i added/improved the following:
$out/share/photoprismdevelopwhen runningphotoprism --version)Currently runs in a nixos container on my storage server as a simple systemd service. Haven't looked at the module that has been developed in the previous PR, would use that as a base for a new PR once this one has been merged.
Fixes #96043 Supersedes #170953
It's my first contribution so any help would be really appreciated :)
Note: I ran
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"where one derivation failed (flexoptix-app) getting the AppImage failed with a404.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes