-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: add enableParallelBuilding's to bootstrap packages so hashes stay the same #172962
Conversation
compiled up to sway with 24 cores currently compiling with 40 cores |
compiled up to sway with 40 cores @ofborg build sway |
Derivations which use meson or cmake or ninja also need to have this set explicitly for nix to not change the hashes A proper solution would be to add the attr when meson or cmake or ninja are in nativeBuildInputs |
Sounds good to me, but I think @SuperSandro2000 was removing / suggesting to remove these when a builder that enabled it by default (e.g. indeed cmake or meson) was used. So not sure if we should reintroduce them again. Adding for bootstrap packages is a good idea in general though. |
fab3ed6
to
f0ff334
Compare
Yes but it should hopefully be a no-op when |
f0ff334
to
9d32e06
Compare
removed the commit which adds it to more packages so now its only the bootstrap packages up to bash |
Hopefully these packages all support that well enough to not cause regressions. I'm expecting that your experiments would've shown the worst offenders already, so I think it's good. |
9d32e06
to
91338aa
Compare
@Artturin please resolve the merge conflict. |
…s stay the same when enableParallelBuildingByDefault is enabled verified with `nix-diff $(nix eval ".#gcc-unwrapped.drvPath") $(nix eval --expr 'with import ./. { config = { enableParallelBuildingByDefault = true; }; }; gcc-unwrapped.drvPath' --impure)`
91338aa
to
1d44ac1
Compare
@ofborg build pkg-config |
when enableParallelBuildingByDefault is enabled
verified with
nix-diff $(nix eval ".#gcc-unwrapped.drvPath") $(nix eval --expr 'with import ./. { config = { enableParallelBuildingByDefault = true; }; }; gcc-unwrapped.drvPath' --impure)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes