Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handlr: 0.6.4 -> unstable-2021-08-29 #173502

Merged
merged 1 commit into from
May 21, 2022
Merged

handlr: 0.6.4 -> unstable-2021-08-29 #173502

merged 1 commit into from
May 21, 2022

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented May 18, 2022 •
edited
Loading

the main thing this fixes is crash on read-only mimeapps therefore
making handlr usable with a home-manager managed mimeapps.list

chmln/handlr#54

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin
handlr: 0.6.4 -> unstable-2021-08-29
22eb097 
the main thing this fixes is crash on read-only mimeapps therefore
making handlr usable with a home-manager managed mimeapps.list
@ofborg ofborg bot requested a review from mredaelli May 18, 2022 15:46
Mindavi
Mindavi approved these changes May 21, 2022
View reviewed changes
Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@LunNova
Copy link
Member

LunNova commented May 21, 2022

Should this be using the format from RFC 0107 instead? NixOS/rfcs#107

It's not merged but there are already other packages in nixpkgs using the new format.

@Artturin
Copy link
Member Author

Should this be using the format from RFC 0107 instead? NixOS/rfcs#107

It's not merged but there are already other packages in nixpkgs using the new format.

once its merged it'll be easy to sed all these to the chosen format

@Artturin Artturin merged commit 39c65d7 into NixOS:master May 21, 2022
@Artturin Artturin deleted the handlrupdat branch May 21, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mindavi Mindavi Mindavi approved these changes

@mredaelli mredaelli Awaiting requested review from mredaelli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Artturin @LunNova @Mindavi