nixos/firefox: init

[danth]

Description of changes

Added a module which allows Firefox preferences and policies to be set in the NixOS configuration.

I know this can already be done by overriding the package, however:

• Package overrides are not discoverable on https://search.nixos.org (I've used NixOS for around 1 year and only just found out that the Firefox wrapper supports this)
• Having a proper NixOS option allows other modules to add their policies, for example the IPFS module could optionally enable the IPFS companion extension

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[danth]

@mweinelt @lovesegfault I'm requesting review since you are maintainers of the existing Firefox package. Would you like to be added to the maintainers list of this module, too, if it is merged?

[mweinelt]

I really think home-manager is the better place for a firefox module.

https://github.com/nix-community/home-manager/blob/master/modules/programs/firefox.nix

[linsui]

HM has its own problem and it's not official. I don't want to use HM but I want to config Firefox in my nixos config. For single-user system the module system just works and it can also be used as a system-wide default config for a multi-user system.

[danth]

Also, this creates a policy which prevents the settings from being overridden, which could be useful to an organisation.

There is already a module like this for Chromium so I think it makes sense to add the Firefox equivalent.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/any-chance-to-have-a-firefox-module-in-nixos/23125/1

[AndersonTorres]

@danth ping

[nbp]

For a single user, HM can be used as documented in the Wiki: https://nixos.wiki/wiki/Home_Manager#Usage_as_a_NixOS_module
However, it does make sense for computers managed by a sys-admin, where users might not have the right to delegate to the nix daemon, to setup Firefox with various set of policies dedicated to Enterprise users.

[AndersonTorres]

Is anyone interested on fixing the git conflicts?

[danth]

@AndersonTorres Conflicts are fixed now.

[AndersonTorres]

Now I need someone to test it and someone to fix ofborg's complaint :)

[danth]

Converted the docs to Markdown. That should have fixed the errors regarding the manual

[AndersonTorres]

God bless programs.firefox!