Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nixos/prometheus-smartctl-exporter]: Increase priority on DeviceAllow #176553

Merged
merged 1 commit into from Oct 27, 2022

Conversation

MalteT
Copy link
Contributor

@MalteT MalteT commented Jun 6, 2022

Description of changes

Tweak mkOverride priority on DeviceAllow= for smartctl prometheus exporter service.
Fixes #176524.

Tested in my own config, both with services.prometheus.exporters.smartctl.devices set and without it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@denibertovic
Copy link

I just stumbled on this error yesterday and this fixed it for me. Can we get this merged?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/smartctl-exporter/19110/7

@mweinelt mweinelt merged commit 96d7f29 into NixOS:master Oct 27, 2022
@MalteT MalteT deleted the fix/smartctl-exporter-override branch October 27, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation not permitted from prometheus.exporters.smartctl
4 participants