Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: bugfix: add check for empty file for secrets #177573

Merged
merged 1 commit into from Jul 28, 2022

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Jun 13, 2022

There are some cases were the files are present but not filled with secrets. In these cases the service fails to startup.

This fixes #175967

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

There are some cases were the files are present but not filled with secrets. In these cases the service fails to startup.

This fixes NixOS#175967
@SuperSandro2000
Copy link
Member

Wouldn't it be a good idea to log something if the secret is empty instead of silently ignoring it?

@asbachb
Copy link
Contributor Author

asbachb commented Jul 28, 2022

Wouldn't it be a good idea to log something if the secret is empty instead of silently ignoring it?

From my understanding the idea is to generate secrets if they're not provided.

The problem with current behavior just pops up when you had a previous installation of gitea.

@SuperSandro2000 SuperSandro2000 merged commit b5b9c81 into NixOS:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitea: Unbale to start service due to "permission denied"
4 participants