-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kdigger: init at 1.2.0 #177868
kdigger: init at 1.2.0 #177868
Conversation
Related to #81418 |
Patch to simplify ldflags and clarify their purpose Since aarch64-linux and x86_64-darwin fail to build I've just marked this as x86_64-linux only |
|
||
preBuild = '' | ||
ldflags+=" -X github.com/quarkslab/kdigger/commands.GITCOMMIT=$(cat COMMIT)" | ||
ldflags+=" -X github.com/quarkslab/kdigger/commands.BUILDERARCH=$(uname -m)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ldflags+=" -X github.com/quarkslab/kdigger/commands.BUILDERARCH=$(uname -m)" |
Thats impure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How so, shouldn't it always be x86-64 on an x86_64 builder and aarch64 if crosscompiled for x86_64-linux from an aarch64-linux platform?
It doesnt have other details like kernel label/name/whatever, date, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I can pull an equivalent value from stdenv somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right. I thought it includes the x86_64 variants but we still shouldn't use it because it depends on the build machine and not the nixpkgs platform. Also it probably breaks easily on binfmt.
Successfully created backport PR #178067 for |
Description of changes
Package kdigger for nixpkgs @ 1.2.0
https://github.com/quarkslab/kdigger
Wait to see if x86_64-darwin builds
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes