Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baekmuk-ttf: fix hash #18166

Closed
wants to merge 1 commit into from
Closed

baekmuk-ttf: fix hash #18166

wants to merge 1 commit into from

Conversation

listx
Copy link
Member

@listx listx commented Aug 31, 2016

Motivation for this change

Tested with nix-prefetch-url http://kldp.net/baekmuk/release/865-baekmuk-ttf-2.2.tar.gz

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@listx, thanks for your PR! By analyzing the annotation information on this pull request, we identified @matthewbauer and @dezgeg to be potential reviewers

@joachifm
Copy link
Contributor

Note that

nix-hash --type sha256 --to-base32 08ab7dffb55d5887cc942ce370f5e33b756a55fbb4eaf0b90f244070e8d51882
10hqspl70h141ywz1smlzdanlx9vwgsp1qrcjk68fn2xnpzpvaq8

Looks like this PR only changes the base (which is okay, I suppose, base32 is more pleasing to the eye).

@listx
Copy link
Member Author

listx commented Sep 1, 2016

Thank you for that bit of info. I did not realize they were the same.
Still, I think the patch makes sense because base32 is what Nix reports
during builds.

On Aug 31, 2016 12:24 PM, "Joachim F." notifications@github.com wrote:

Note that

nix-hash --type sha256 --to-base32 08ab7dffb55d5887cc942ce370f5e3
3b756a55fbb4eaf0b90f244070e8d51882
10hqspl70h141ywz1smlzdanlx9vwgsp1qrcjk68fn2xnpzpvaq8

Looks like this PR only changes the base (which is okay, I suppose, base32
is more pleasing to the eye).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#18166 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAsSbbVKU5uOS7sdG0R5L-L56g7iQLNfks5qldTXgaJpZM4Jx4MK
.

@joachifm joachifm closed this in 511bb28 Sep 1, 2016
@joachifm
Copy link
Contributor

joachifm commented Sep 1, 2016

Merged as 511bb28 with an updated commit message.

@listx
Copy link
Member Author

listx commented Sep 1, 2016

Thanks!

On Sep 1, 2016 7:43 AM, "Joachim F." notifications@github.com wrote:

Merged as 511bb28
511bb28
with an updated commit message.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#18166 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAsSbcRZwIzMd6kzZbbHxy5vMHcsW7Auks5qluRggaJpZM4Jx4MK
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants