invoiceplane: Mark as broken, missing php 8 support #182557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (fetchpatch { | ||
| url = "https://github.com/InvoicePlane/InvoicePlane/commit/694ba97d6e207bd4357ce4d2992601f0320f69fe.patch"; | ||
| sha256 = "sha256-6ksJjW6awr3lZsDRxa22pCcRGBVBYyV8+TbhOp6HBq0="; | ||
| name = "cve-2021-29022-fix.patch" |
There was a problem hiding this comment.
Suggested change
| name = "cve-2021-29022-fix.patch" | |
| name = "cve-2021-29022-fix.patch"; |
|
Dont we stil lhave php7? |
|
I think it goes dropped completely #174555 |
Comment on lines
+60
to
+63
| description = '' | ||
| Self-hosted open source application for managing your invoices, clients | ||
| and payments | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| description = '' | |
| Self-hosted open source application for managing your invoices, clients | |
| and payments | |
| ''; | |
| description = "Self-hosted open source application for managing your invoices, clients and payments"; |
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Temporary mark invoiceplane as broken because current stable version is missing PHP8 support.
It's possible that they'll release a new version soon so I don't want to drop the package yet InvoicePlane/InvoicePlane#798
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes