nixos/proxmox-image: allow building UEFI images

[otopetrik]

Description of changes

Allow building other than Legacy-BIOS-only Proxmox images.
Default remains unchanged.

To build UEFI proxmox image use:
proxmox.qemuConf.bios = "ovmf";
(default is "seabios")

To build image bootable using both "seabios" and "ovmf" use:
diskPartitioning = "hybrid";
BIOS can be switched in Proxmox between "seabios" and "ovmf" and VM still boots.
(GRUB2-only, systemd-boot does not boot under "seabios")

To build systemd-boot UEFI image:
proxmox.qemuConf.bios = "ovmf";
boot.loader.systemd-boot.enable = true;

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[otopetrik]

Example flake building different image types: https://github.com/otopetrik/proxmox-nixos-image-build-check

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1024

[RaitoBezarius]

LGTM.

[otopetrik]

Hello @illustris, it looks like you have committed the latest change to this file and authored almost all the changes since this pull request was created.
Could you please merge it or provide feedback ? Thanks.

[illustris]

I've been trying to find time to do this myself. Thanks! I tried building and booting different combinations of bios and partitionTableType. Looks good.

In addition to the (optional) changes in this review, please mention this change in the release notes.

[otopetrik]

Thanks for the review.
Option renamed to partitionTableType, release notes updated.

Example repository updated to use cloud-init and terraform to check that resulting images are working.

[otopetrik]

Hello @SuperSandro2000, it looks like you are the last one to merge a proxmox-image pull request.
Could you please merge this one or provide feedback ? Thanks.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/670

[otopetrik]

Changes applied.
Thanks for the review.

[otopetrik]

It has been two weeks since the last revision, and no new comments.
I'm assuming that the current version is acceptable.
@SuperSandro2000 could you please merge this pull-request ? Thanks.

[mweinelt]

Should have received the backport label, since it touched the release notes post branch-off. Caused conflicts.... Backported in #203777.