Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exportarr: init at 1.1.0 #183772

Merged
merged 1 commit into from
Jul 29, 2022
Merged

exportarr: init at 1.1.0 #183772

merged 1 commit into from
Jul 29, 2022

Conversation

azahi
Copy link
Member

@azahi azahi commented Jul 29, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Sep 5, 2022

  • This should be moved into pkgs/servers/monitoring/prometheus.
  • What's up with all the short opts in ldFlags, isn't there something more readable?
  • Why force a static build for Linux systems?

@azahi
Copy link
Member Author

azahi commented Sep 5, 2022

  • This should be moved into pkgs/servers/monitoring/prometheus.

Agreed.

  • What's up with all the short opts in ldFlags, isn't there something more readable?

-s and -w are linker flags, there are no verbose counterparts to them.

  • Why force a static build for Linux systems?

I used this as a reference. But looking at it now, it would be preferable to use dynamic linking because Nix handles it very well.

I'll make a follow up PR later.

@azahi azahi deleted the exportarr branch September 6, 2022 08:59
azahi added a commit to azahi/nixpkgs that referenced this pull request Sep 6, 2022
Applied suggestions[1] from @mweinelt and did a small refactor.

[1]: NixOS#183772 (comment)
@azahi azahi mentioned this pull request Sep 6, 2022
13 tasks
RaitoBezarius pushed a commit to RaitoBezarius/nixpkgs that referenced this pull request Sep 17, 2022
Applied suggestions[1] from @mweinelt and did a small refactor.

[1]: NixOS#183772 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants