Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/peertube: add nginx configuration #191061

Merged
merged 1 commit into from Oct 21, 2022
Merged

nixos/peertube: add nginx configuration #191061

merged 1 commit into from Oct 21, 2022

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Sep 13, 2022

Description of changes

Add nginx configuration.

cc @marsam @mohe2015 @immae @SuperSandro2000

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea if the settings are correct though

nixos/modules/services/web-apps/peertube.nix Show resolved Hide resolved
@Izorkin Izorkin marked this pull request as draft October 17, 2022 20:55
@Izorkin Izorkin marked this pull request as ready for review October 18, 2022 20:33
@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 18, 2022

Added small fixes.
cc @SuperSandro2000

SuperSandro2000
SuperSandro2000 reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with those last formatting changes.

I assume you tested this in a deployment? If no one else has anything to add I would merge this after this.

nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/peertube.nix Outdated Show resolved Hide resolved
@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 20, 2022

@SuperSandro2000 fixed!

@SuperSandro2000 SuperSandro2000 merged commit 0d1e0a9 into NixOS:master Oct 21, 2022
@Izorkin Izorkin deleted the update-peertube-nginx branch October 21, 2022 22:08
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #197127 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @SuperSandro2000