-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.{pep,flake8}: undo changes from #19104 #19132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0986a17. ---- pycodestyle and pep8 are not api compatible so the alias adds little value. Packages that are compatible with pycodestyle should be updated to use the new version on a per package basis.
yep that PR shouldn't have been merged. |
can you undo flake8 as well? |
groxxda
changed the title
Revert "pep8: replaced by pycodestyle (package was renamed)"
pythonPackages.{pep,flake8}: undo changes from #19104
Oct 1, 2016
7 tasks
oh, looks like mccabe also needs reverting.. |
i'll post a follow up pr in a minute |
FRidh
added a commit
that referenced
this pull request
Oct 2, 2016
This reverts commit 532869c. See #19132 (comment)
@FRidh sorry I somehow forgot to file the pr after hours of rebuilding 😞 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This change introduces breakage because
pycodestyle
andpep8
are not API compatible and packages have not yet been updated.The packages that are compatible should be converted to use
pycodestyle
on a per-package basis.Introduced in #19104
That PR also updates flake8 which breaks stuff.
This fixes virtmanager.
CC @mbld @Mic92 @garbas
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)This reverts commit 0986a17.