Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.{pep,flake8}: undo changes from #19104 #19132

Merged
merged 3 commits into from
Oct 1, 2016
Merged

pythonPackages.{pep,flake8}: undo changes from #19104 #19132

merged 3 commits into from
Oct 1, 2016

Conversation

groxxda
Copy link
Contributor

@groxxda groxxda commented Oct 1, 2016

Motivation for this change

This change introduces breakage because pycodestyle and pep8 are not API compatible and packages have not yet been updated.
The packages that are compatible should be converted to use pycodestyle on a per-package basis.

Introduced in #19104
That PR also updates flake8 which breaks stuff.

This fixes virtmanager.

CC @mbld @Mic92 @garbas

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This reverts commit 0986a17.

This reverts commit 0986a17.

----

pycodestyle and pep8 are not api compatible so the alias adds little
value.

Packages that are compatible with pycodestyle should be updated to use
the new version on a per package basis.
@mention-bot
Copy link

@groxxda, thanks for your PR! By analyzing the annotation information on this pull request, we identified @FRidh to be a potential reviewer

@FRidh
Copy link
Member

FRidh commented Oct 1, 2016

yep that PR shouldn't have been merged.

@FRidh
Copy link
Member

FRidh commented Oct 1, 2016

can you undo flake8 as well?

groxxda and others added 2 commits October 1, 2016 18:06
This reverts commit 7026cdf.
This reverts commit 0675eb1.
This reverts commit 3c88d3a.

---

flake8 versions 2 and 3 are api incompatible and this update breaks
stuff. Version 3 should be added as a seperate expression and compatible
packages should use it explicitly.
(cherry picked from commit 7026cdf)
(cherry picked from commit 0675eb1)
(cherry picked from commit 3c88d3a)

---

initializes a new version of flake8 as a seperate expression.

Signed-off-by: Alexander Ried <ried@mytum.de>
@groxxda
Copy link
Contributor Author

groxxda commented Oct 1, 2016

@FRidh done
built python35Packages.flake8{_3}
Let me know if the package should have an other name. Also flake8_3 lacks a maintainer as I'm not sure whether @garbas want's to maintain it.

Please don't squash merge 😉

@groxxda groxxda changed the title Revert "pep8: replaced by pycodestyle (package was renamed)" pythonPackages.{pep,flake8}: undo changes from #19104 Oct 1, 2016
@FRidh FRidh merged commit 539e9fc into NixOS:master Oct 1, 2016
@groxxda
Copy link
Contributor Author

groxxda commented Oct 1, 2016

oh, looks like mccabe also needs reverting..

@groxxda
Copy link
Contributor Author

groxxda commented Oct 1, 2016

i'll post a follow up pr in a minute

@groxxda groxxda deleted the pep8 branch October 1, 2016 19:42
@FRidh
Copy link
Member

FRidh commented Oct 2, 2016

@groxxda done in 25dcdc5

FRidh added a commit that referenced this pull request Oct 2, 2016
@groxxda
Copy link
Contributor Author

groxxda commented Oct 2, 2016

@FRidh sorry I somehow forgot to file the pr after hours of rebuilding 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants