Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune old aliases #192681

Merged
merged 2 commits into from Sep 25, 2022
Merged

Prune old aliases #192681

merged 2 commits into from Sep 25, 2022

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 24, 2022

This removes throws older than 2021-09-01, converts aliases older than
2021-09-01 to throws and fills in missing dates here and there.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This removes throws older than 2021-09-01, converts aliases older than
2021-09-01 to throws and fills in missing dates here and there.
This removes throws odler than 2021-09-01, converts aliases older than
2021-09-01 to throws and fills in missing dates in two cases.
@mweinelt mweinelt merged commit 2d74c25 into NixOS:master Sep 25, 2022
@mweinelt mweinelt deleted the prune-aliases branch September 25, 2022 00:59
booklearner added a commit to booklearner/nixconfig that referenced this pull request Sep 25, 2022
Seems like `runCommandNoCC` is creating issues, might be temporary. See NixOS/nixpkgs#192681
m15a pushed a commit to m15a/flake-awesome-neovim-plugins that referenced this pull request Sep 26, 2022
sigprof added a commit to sigprof/nur-packages that referenced this pull request Sep 26, 2022
The rename was done long ago in NixOS/nixpkgs#122107 (back in 21.05),
and since NixOS/nixpkgs#192681 the old `gnome3` name no longer works.
Update the old virt-manager package accordingly.
sigprof added a commit to sigprof/nur-packages that referenced this pull request Sep 26, 2022
The rename was done long ago in NixOS/nixpkgs#122107 (back in 21.05),
and since NixOS/nixpkgs#192681 the old `gnome3` name no longer works.
Update the old virt-manager package accordingly.
marsam added a commit to marsam/pdf-tools that referenced this pull request Sep 26, 2022
Recently nixpkgs removed the `pkgconfig` alias [1], which broke the
build with nix-shell.

[1] NixOS/nixpkgs#192681
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/mpv-with-scripts-has-been-renamed/22017/3

andersk added a commit to andersk/nixpkgs-mozilla that referenced this pull request Sep 26, 2022
It has been synonymous with runCommand since
NixOS/nixpkgs@97bfc2f
(2016-09-26), was deprecated in
NixOS/nixpkgs#134225 (2021-08-15), and was
removed in NixOS/nixpkgs#192681 (2022-09-24).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
zhaofengli added a commit to zhaofengli/colmena that referenced this pull request Sep 29, 2022
No longer exists in unstable since NixOS/nixpkgs#192681.
zhaofengli added a commit to zhaofengli/colmena that referenced this pull request Sep 29, 2022
No longer exists in unstable since NixOS/nixpkgs#192681.
@zhaofengli zhaofengli mentioned this pull request Sep 29, 2022
13 tasks
mutt-with-sidebar = mutt; # Added 2022-09-17
mysql-client = hiPrio mariadb.client;
mysql = mariadb; # moved from top-level 2021-03-14
mysql-client = throw "'mysql-client' has been renamed to/replaced by 'hiPrio'"; # Converted to throw 2022-09-24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this message to ...replaced by 'mariadb.client'? This thoroughly confused me for a moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in maintainers/scripts/remove-old-aliases.py then. Feel free to submit a PR yourself, I'm currently otherwise occupied.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included fixing the generated line in PR #193914

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

vcunat added a commit to vcunat/nixpkgs that referenced this pull request Oct 1, 2022
vedang pushed a commit to vedang/pdf-tools that referenced this pull request Oct 3, 2022
Recently nixpkgs removed the `pkgconfig` alias[^1], which broke the
build with `nix-shell`.

[^1]: NixOS/nixpkgs#192681

Closes: #153
Closes: #158
nbp pushed a commit to mozilla/nixpkgs-mozilla that referenced this pull request Oct 3, 2022
It has been synonymous with runCommand since
NixOS/nixpkgs@97bfc2f
(2016-09-26), was deprecated in
NixOS/nixpkgs#134225 (2021-08-15), and was
removed in NixOS/nixpkgs#192681 (2022-09-24).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andrew-d added a commit to andrew-d/zpool-exporter-textfile that referenced this pull request Oct 3, 2022
@vcunat vcunat mentioned this pull request Oct 5, 2022
13 tasks
vcunat added a commit that referenced this pull request Oct 5, 2022
@rapenne-s rapenne-s mentioned this pull request Oct 5, 2022
13 tasks
bors-servo added a commit to servo/servo that referenced this pull request Oct 9, 2022
`etc/shell.nix`: Replace `pkgconfig` with `pkg-config`

`pkgconfig` is [an old name][1] of `pkg-config` that has been [completely removed][2] in a recent version of nixpkgs.

[1]: NixOS/nixpkgs#55094
[2]: NixOS/nixpkgs#192681

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

---
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they don't affect the production code
@roberth roberth mentioned this pull request Oct 14, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants