nix-prefetch-git: fix json output. #19369
Conversation
|
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryantrinkle, @DavidEGrayson and @timbertson to be potential reviewers. |
|
This is becoming a big nightmare. Could we use a library to generate/escape the json? |
|
Well, it looks like any decent programming languages gets replaced by brittle shell scripts in Nixos. |
|
Haskell would be a good choice! Some other developers and I made a related utility using Haskell: |
|
But this tools does not replace nix-fetch-git really. |
Mic92
force-pushed
the
nix-prefetch-git
branch
from
62eb821
to
40fb3e0
Compare
|
Are the zfstools and rancher-compose changes related to this PR? |
Mic92
force-pushed
the
nix-prefetch-git
branch
from
40fb3e0
to
62eb821
Compare
json requires certain characters to be escaped in strings.
in some cases `git show` include tag information in the output this is suppressed by the parameter '-1'
Mic92
force-pushed
the
nix-prefetch-git
branch
from
62eb821
to
47d0d3d
Compare
|
@fpletz no, rebased against the wrong master. This is fixed now. |
|
merged because nobody seems to work on a better solution and this one still fix the problem. |
Motivation for this change
fix json output
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)