Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrum: make compatible with protobuf 4+ #194112

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 2, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@austinbutler
Copy link
Member

Result of nixpkgs-review pr 194112 run on x86_64-linux 1

1 package built:
  • electrum

@prusnak prusnak merged commit 01c6a05 into NixOS:master Oct 4, 2022
@prusnak prusnak deleted the electrum branch October 4, 2022 08:20
@oxalica
Copy link
Contributor

oxalica commented Oct 7, 2022

Doesn't is just hide the existing issue? It's intentional to mark as not supporting protobuf 4. spesmilo/electrum#7922

@prusnak
Copy link
Member Author

prusnak commented Oct 8, 2022

Doesn't is just hide the existing issue? It's intentional to mark as not supporting protobuf 4. spesmilo/electrum#7922

Not really. Upstream wants to keep old pb2.py file to support older protobuf. We regenerate the pb2.py file to new version, because we don't care about older protobuf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electrum: fails to build on x86_64
4 participants