zlib: 1.2.12 -> 1.2.13 #196167
Merged
zlib: 1.2.12 -> 1.2.13 #196167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build pkgsCross.aarch64-multiplatform.zlib zlib |
|
@ofborg build pkgsCross.aarch64-embedded.zlib still fails (not a regression) |
mweinelt
reviewed
Oct 15, 2022
SuperSandro2000
approved these changes
Oct 15, 2022
|
qt5.qtbase builds |
|
Successfully built |
13 tasks
|
Does it fetch for you successfully? When I try to fetch it in |
|
Looks OK to me However, on sourceforge I see only versions up to 1.2.11: https://sourceforge.net/projects/libpng/files/zlib/ |
|
Hm: Looks like I'm catpcha'd: Apologies for the noise. |
Artturin
commented
Oct 17, 2022
| @@ -23,14 +23,14 @@ assert splitStaticOutput -> static; | |||
|
|
|||
| stdenv.mkDerivation (rec { | |||
| pname = "zlib"; | |||
| version = "1.2.12"; | |||
| version = "1.2.13"; | |||
|
|
|||
| src = fetchurl { | |||
| urls = | |||
| [ "https://www.zlib.net/fossils/zlib-${version}.tar.gz" # stable archive path | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
That's bad, as that URL disappears on every release. They only keep the last one there.
There was a problem hiding this comment.
It's why the "stable archive path" comment is there.
That's a bit of a problem. Could we maybe fallback to a mirror? or reach out to upstream? |
|
E.g. like this? #196910 |
SuperSandro2000
pushed a commit
that referenced
this pull request
Oct 20, 2022
On sourceforge I see only versions up to 1.2.11: https://sourceforge.net/projects/libpng/files/zlib/ and the order is switched to avoid captcha (I didn't encounter it): #196167 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes