bazarr: 1.1.1 -> 1.1.2

[andreisergiu98]

Description of changes

Updated bazarr
Closes #196226

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[NULLx76]

The commit message for 461470b9f3a6ed65fd901549e36ef36683957a80, should probably be prefixed with something like nixos/tests/bazarr: or just squashed into the other commit

[andreisergiu98]

@NULLx76 done

[bjornfor]

The test needs more fixing, it even fails on master (after applying the fix from this PR).

[06kellyjac]

As an aside: I use unrar-wrapper which has the free unar stand in place for the unfree unrar and it seems to work fine

bazarr = prev.bazarr.override { unrar = prev.unrar-wrapper; };

Probably not something we should do by default until the bazarr maintainers say it's supported but since unrar being unfree was mentioned I thought I'd post this :)

[bjornfor]

If you add time.timeZone = "UTC"; to the nixos test configuration the test also pass. Apparently bazarr tries to use UTC itself when no timezone is given, but it fails. Explicitly setting the timezone seems to work.

[bjornfor]

If you add time.timeZone = "UTC"; to the nixos test configuration the test also pass. Apparently bazarr tries to use UTC itself when no timezone is given, but it fails. Explicitly setting the timezone seems to work.

I made an upstream issue: morpheus65535/bazarr#1983

[andreisergiu98]

So should we add time.timeZone = "UTC" to the test or should we ignore the errors until it is fixed upstream?
Regarding unrar, bazarr 1.1.3 added support for unar, so I think it's safer to switch to it when it's released.

[06kellyjac]

bazarr 1.1.3 added support for unar, so I think it's safer to switch to it when it's released.

yoooo, awesome

[bjornfor]

So should we add time.timeZone = "UTC" to the test or should we ignore the errors until it is fixed upstream?

I would integrate that fix into the/a "nixos/tests/bazarr: fix it" commit, then do the version bump.

[bjornfor]

I would integrate that fix into the/a "nixos/tests/bazarr: fix it" commit, then do the version bump.

I did that here: #199517

[andreisergiu98]

Cool! After you merge it, I'll drop the commit on the test and leave only the bump.

[bjornfor]

Cool! After you merge it, I'll drop the commit on the test and leave only the bump.

Merged.

[bjornfor]

Rebased on master and nix-build ./nixos/tests/bazarr.nix passed.