Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/bazarr: fix it #199517

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Nov 4, 2022

Description of changes

Fix ./nixos/tests/bazarr.nix so that it builds/runs successfully.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The test still doesn't pass, it has some runtime issues as well.

Fixes: 5803706 ("nixos/tests: fix type mismatch in wait_for_open_port")
@bjornfor bjornfor changed the title nixos/bazarr: fix test nixos/tests/bazarr: fix it Nov 4, 2022
@bjornfor bjornfor mentioned this pull request Nov 4, 2022
13 tasks
@bjornfor bjornfor merged commit 8973da1 into NixOS:master Nov 4, 2022
@bjornfor bjornfor deleted the nixos-bazarr-fix-test branch November 4, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants