Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shot-scraper: init at 1.1.1 #196974

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Oct 20, 2022

Description of changes

https://github.com/simonw/shot-scraper/releases/tag/1.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Related to #81418

@fabaff

This comment was marked as outdated.

@techknowlogick techknowlogick changed the title shot-scraper: init at 1.0 shot-scraper: init at 1.1.1 Mar 20, 2023
@fabaff
Copy link
Member

fabaff commented Mar 20, 2023

Result of nixpkgs-review pr 196974 run on x86_64-linux 1

1 package built:
  • shot-scraper

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.maintainers is set
  • package builds (see shot-scraper: init at 1.1.1 #196974 (comment))
  • all depending packages build
  • tested on x86_64
...ew/pr-196974]$ ./results/shot-scraper/bin/shot-scraper 
Usage: shot-scraper shot [OPTIONS] URL
Try 'shot-scraper shot --help' for help.

Error: Missing argument 'URL'.

Looks good to me.

@fabaff fabaff merged commit b6b5187 into NixOS:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants