Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwdata: 0.360 -> 0.363 #197538

Merged
merged 1 commit into from
Nov 9, 2022
Merged

hwdata: 0.360 -> 0.363 #197538

merged 1 commit into from
Nov 9, 2022

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Oct 24, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@iblech
Copy link
Contributor Author

iblech commented Oct 24, 2022

Note: This change may be affected by NixOS/nix#6572.

nix-shell -I nixpkgs=... -p hwdata correctly produces the expected files in /nix/store/acgi1g8vkllzmlhvi8kla0n0qga853hk-hwdata-0.363, however it warns build input /nix/store/5w9wnk36rx4ycyg2p7hf034yviphk9x2-hwdata-0.363 does not exist and pciutils for instance requires the files to be in the latter location instead of the former.

I don't know how to debug this.

@LunNova
Copy link
Member

LunNova commented Oct 30, 2022

This probably needs to target staging due to the mass rebuild.

@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging November 9, 2022 10:58
@iblech
Copy link
Contributor Author

iblech commented Nov 9, 2022

Awesome, thank you for tending to this pull request, @SuperSandro2000!

I can confirm that building hwdata and pciutils work correctly and without warnings. (I don't quite understand why it didn't work as a FOD, even though it had been that way for quite some time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants