unigine-valley: init at 1.0-1 #19813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kierdavis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @edolstra and @peti to be potential reviewers. |
NeQuissimus
reviewed
Oct 24, 2016
| description = "The Unigine Valley GPU benchmarking tool"; | ||
| homepage = "http://unigine.com/products/benchmarks/valley/"; | ||
| license = stdenv.lib.licenses.unfree; # see also: /nix/store/*-unigine-valley-1.0/opt/unigine/valley/documentation/License.pdf | ||
| maintainers = [ stdenv.lib.maintainers.kier ]; # Kier Davis <kierdavis@gmail.com> |
There was a problem hiding this comment.
Since this information can be looked up in the maintainers file, I would not put the comment here
|
I've just merged this in to master. Thank you for your contribution. I've made two changes:
Thank you! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add Unigine Valley GPU benchmarking application. Provides one executable,
valley, which starts the launcher (from which you can configure graphics settings before beginning the benchmark).Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Sandboxing tested by setting
nix.useSandbox = trueand runningnix-shell -I nixpkgs=. -p unigine-valley --run valleyin a local checkout of this branch.