cotp: init at 1.1.0

[DavSanchez]

This is a follow-up on #200427 which was closed due to me messing up while rebasing (sorry!)

In case I need additional changes, I'm opening it as a draft so I can take more time to review.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[DavSanchez]

Sorry about the format issues @azahi , I read somewhere that alejandra was being used for formatting and applied it, but perhaps I read it somewhere else and mixed up. For future contributions, perhaps should I use nixfmt instead?

[azahi]

should I use nixfmt instead

No, don't use that. There are no specific guidelines on how to format Nix code for Nixpkgs (well, at least that I know of), just try to mimic what's already there. If you need a formatter you can use nixpkgs-fmt, but it's not "official" per se.

There's also an RFC about that if you are interested.

[azahi]

Evaluation is currently failing, you need to fix that and then please squash your commits. You should have two commits ready to merge: one which adds yourself as a maintainer, and one which creates the package itself. You can find out how to correctly format commit messages in CONTRIBUTING.md or just look at the git logs and see what other people are doing.

[azahi]

Looks great! The only think left is that you should remove the v prefix for version in your commit message, it should be like this: cotp: init at 1.1.0.

[DavSanchez]

Looks great! The only think left is that you should remove the v prefix for version in your commit message, it should be like this: cotp: init at 1.1.0.

Done!

[azahi]

Apparently I've missed these two:

[azahi]

Result of nixpkgs-review pr 200434 run on x86_64-linux 1

1 package built:

• cotp