Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quodlibet: Add WMA support #204878

Merged
merged 1 commit into from
Jan 12, 2023
Merged

quodlibet: Add WMA support #204878

merged 1 commit into from
Jan 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2022 •
edited by ghost
Loading

Description of changes

Adds libav to the build inputs of quodlibet, which allows it to play .wma files.

Tested locally and in a VM with file samples from https://filesamples.com/formats/wma

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Closes #204695

quodlibet: Add WMA support
2b191a3 
The issue already popped up with rhythmbox and this is the application of
 the solution from https://github.com/NixOS/nixpkgs/pull/130118/files

Related to #204695
@ofborg ofborg bot requested a review from pbogdan December 6, 2022 22:51
@k0ral
Copy link
Contributor

k0ral commented Dec 6, 2022

I've tested this change and I confirm that:

  • quodlibet installed from master branch is unable to play WMA files, and shows the following dialog:

    image

  • quodlibet installed using nix-build -A quodlibet https://github.com/LoveIsGrief/nixpkgs/archive/refs/heads/quodlibet-wma.zip is capable of playing WMA files

@ghost
Copy link
Author

ghost commented Dec 18, 2022

@coroa @pbogdan could you review?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1693

@SuperSandro2000 SuperSandro2000 merged commit bbde45a into NixOS:master Jan 12, 2023
@ghost ghost deleted the quodlibet-wma branch January 13, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan Awaiting requested review from pbogdan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quodlibet cannot play WMA files
3 participants
@k0ral @nixos-discourse @SuperSandro2000