Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lunarml: init at unstable-2023-06-25 #205407

Merged
merged 1 commit into from
Jul 16, 2023
Merged

lunarml: init at unstable-2023-06-25 #205407

merged 1 commit into from
Jul 16, 2023

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Dec 10, 2022

Description of changes

https://github.com/minoki/LunarML

doCheck passes their built-in tests. I had a chat with the upstream project and got it slightly restructured in a way that cut the Nix code by 2/3.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@toastal toastal force-pushed the lunarml branch 2 times, most recently from 6c338a4 to 3b6b111 Compare December 14, 2022 14:42
@toastal toastal changed the title lunarml: init @ unstable-2022-12-12 lunarml: init at unstable-2022-12-12 Dec 14, 2022
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 97473c1 to b7f4019 Compare December 19, 2022 05:04
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 5ec8a3a to 0df3ed7 Compare December 20, 2022 16:42
@toastal toastal force-pushed the lunarml branch 4 times, most recently from 66b30df to 63d020d Compare December 25, 2022 18:09
@toastal toastal force-pushed the lunarml branch 4 times, most recently from c4e9569 to c55cc15 Compare June 28, 2023 04:55
@toastal toastal force-pushed the lunarml branch 2 times, most recently from b6e88b8 to 5fb08ca Compare July 7, 2023 04:54
@toastal toastal changed the title lunarml: init at unstable-2022-02-12 lunarml: init at unstable-2023-06-25 Jul 7, 2023
@toastal toastal requested a review from ncfavier July 7, 2023 05:13
@toastal toastal force-pushed the lunarml branch 3 times, most recently from d7a578b to 801dc9e Compare July 7, 2023 06:08
@toastal
Copy link
Contributor Author

toastal commented Jul 7, 2023

@ncfavier I tried to use multiple outputs but the binary is very finicky about where lib is. It must be located absolutely from ../lib which if lib is at $lib, then it will be at a different absolute path in the Nix store. Not even a symlink is followed.

@ncfavier
Copy link
Member

ncfavier commented Jul 7, 2023

I didn't ask to move lib

@toastal toastal force-pushed the lunarml branch 5 times, most recently from 7812e44 to 4e08ed6 Compare July 15, 2023 18:16
pkgs/development/compilers/lunarml/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/lunarml/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/lunarml/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/lunarml/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/lunarml/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/lunarml/default.nix Outdated Show resolved Hide resolved
@toastal toastal force-pushed the lunarml branch 3 times, most recently from acc3ba8 to 35fd8a6 Compare July 16, 2023 05:49
@ncfavier ncfavier merged commit 16c3a09 into NixOS:master Jul 16, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants