haskell/hoogle.nix: make an empty packages list possible #20619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cstrahan, @oxij and @mdorman to be potential reviewers. |
peti
reviewed
Nov 21, 2016
| @@ -51,21 +51,19 @@ let | |||
| else writeText "ghcjs-prologue.txt" '' | |||
| This index includes documentation for many Haskell modules. | |||
| ''; | |||
|
|
|||
| docPackages = (lib.closePropagation packages); | |||
There was a problem hiding this comment.
I suppose those brackets are no longer necessary.
|
I'm not fond of the warning. If we consider |
Profpatsch
force-pushed
the
ghcWithHoogle-empty-packagelist
branch
from
41b9440
to
8b68e0e
Compare
|
You are right. I also noticed |
|
Very cool. Once #20619 (comment) is addressed, I'd be happy to merge. |
Building hoogle environments with an empty list of packages threw a built-time error. This was particularly confusing when giving e.g. `(hps: [hps.Cabal])` which, since `Cabal` is set to `null` (because it’s a distribution package), would have lead to the same error as an empty list. It was not useful to throw an error at all, because sometimes one only wants to build an environment for the distribution packages; also the default value for packages wasn’t even a valid value, so it is removed.
Profpatsch
force-pushed
the
ghcWithHoogle-empty-packagelist
branch
from
8b68e0e
to
b8a69aa
Compare
|
Right, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building hoogle environments with an empty list of packages threw a built-time
error. This was particularly confusing when giving e.g.
(hps: [hps.Cabal])which, since
Cabalis set tonull(because it’s a distribution package),would have lead to the same error as an empty list.
It was not useful to throw an error at all, because sometimes one only wants to
build an environment for the distribution packages. We switch to displaying a
warning (because it might be that the user made a mistake).
cc @peti @cstrahan