Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallia: 1.0.3 -> 1.1.4 #206209

Merged
merged 3 commits into from Jan 29, 2023
Merged

gallia: 1.0.3 -> 1.1.4 #206209

merged 3 commits into from Jan 29, 2023

Conversation

rumpelsepp
Copy link
Contributor

@rumpelsepp rumpelsepp commented Dec 15, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@rumpelsepp
Copy link
Contributor Author

Sry, I am a beginner in packaging nix stuff. 😅 Is it required to somehow label the gallia package that it only runs on linux?

@wd15
Copy link
Contributor

wd15 commented Dec 20, 2022

nix-build -A gallia works for me on this branch. However, running nixpkgs-review pr 206209 seems to take an eternity. Approving.

@rumpelsepp
Copy link
Contributor Author

In the meanwhile gallia 1.1.2 was released. I bumped the version number accordingly.

@rumpelsepp rumpelsepp changed the title gallia: 1.0.3 -> 1.1.1 gallia: 1.0.3 -> 1.1.2 Dec 22, 2022
@ofborg ofborg bot requested a review from wd15 December 22, 2022 14:54
pkgs/tools/security/gallia/default.nix Show resolved Hide resolved
pkgs/tools/security/gallia/default.nix Outdated Show resolved Hide resolved
@fabaff
Copy link
Member

fabaff commented Dec 22, 2022

Is it required to somehow label the gallia package that it only runs on linux?

Add platforms = platforms.linux; to meta.

@rumpelsepp rumpelsepp changed the title gallia: 1.0.3 -> 1.1.2 gallia: 1.0.3 -> 1.1.3 Dec 23, 2022
@rumpelsepp
Copy link
Contributor Author

I updated msgspec upstream, such that we can avoid patching pyproject.toml here.

@rumpelsepp
Copy link
Contributor Author

Can you give me a pointer how I can fix the tabulate build? They changed from setup.py to pyproject.toml and I can not get my head around how I do this in nixpkgs. :)

@rumpelsepp
Copy link
Contributor Author

I figure, I fixed it.

@rumpelsepp
Copy link
Contributor Author

rumpelsepp commented Jan 11, 2023

I splitted out the dependencies. Since #208232 is merged, this PR depends on tabulate (already in staging) and #208006.

@@ -16420,4 +16420,10 @@
github = "srounce";
githubId = 60792;
};
rumpelsepp = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add NAME and sort it alphabetically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a separate commit: 874fbfb

Further, this list is not sorted alphabetically in the first place:

wuyoli = {
name = "wuyoli";
email = "wuyoli@tilde.team";
github = "wuyoli";
githubId = 104238274;
};
ziguana = {
name = "Zig Uana";
email = "git@ziguana.dev";
github = "ziguana";
githubId = 45833444;
};
detegr = {
name = "Antti Keränen";
email = "detegr@rbx.email";
github = "Detegr";
githubId = 724433;
};
RossComputerGuy = {
name = "Tristan Ross";
email = "tristan.ross@midstall.com";
github = "RossComputerGuy";
githubId = 19699320;
};
franzmondlichtmann = {
name = "Franz Schroepf";
email = "franz-schroepf@t-online.de";
github = "franzmondlichtmann";
githubId = 105480088;
};
srounce = {
name = "Samuel Rounce";
email = "me@samuelrounce.co.uk";
github = "srounce";
githubId = 60792;
};

So, where should I put my entry?

pkgs/tools/security/gallia/default.nix Outdated Show resolved Hide resolved
@fabaff
Copy link
Member

fabaff commented Jan 28, 2023

Result of nixpkgs-review pr 206209 run on x86_64-linux 1

1 package built:
  • gallia

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@ofborg ofborg bot requested a review from fabaff January 28, 2023 23:59
@fabaff fabaff merged commit 0f5b795 into NixOS:master Jan 29, 2023
@rumpelsepp rumpelsepp deleted the gallia branch January 29, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants