New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gallia: 1.0.3 -> 1.1.4 #206209
gallia: 1.0.3 -> 1.1.4 #206209
Conversation
Sry, I am a beginner in packaging nix stuff. 😅 Is it required to somehow label the |
|
In the meanwhile gallia 1.1.2 was released. I bumped the version number accordingly. |
Add |
33adbcd
to
7e375e6
Compare
I updated msgspec upstream, such that we can avoid patching |
Can you give me a pointer how I can fix the |
I figure, I fixed it. |
0053e84
to
c8a1762
Compare
maintainers/maintainer-list.nix
Outdated
@@ -16420,4 +16420,10 @@ | |||
github = "srounce"; | |||
githubId = 60792; | |||
}; | |||
rumpelsepp = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this into a separate commit with the message maintainers: add NAME
and sort it alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a separate commit: 874fbfb
Further, this list is not sorted alphabetically in the first place:
nixpkgs/maintainers/maintainer-list.nix
Lines 16387 to 16422 in c8a1762
wuyoli = { | |
name = "wuyoli"; | |
email = "wuyoli@tilde.team"; | |
github = "wuyoli"; | |
githubId = 104238274; | |
}; | |
ziguana = { | |
name = "Zig Uana"; | |
email = "git@ziguana.dev"; | |
github = "ziguana"; | |
githubId = 45833444; | |
}; | |
detegr = { | |
name = "Antti Keränen"; | |
email = "detegr@rbx.email"; | |
github = "Detegr"; | |
githubId = 724433; | |
}; | |
RossComputerGuy = { | |
name = "Tristan Ross"; | |
email = "tristan.ross@midstall.com"; | |
github = "RossComputerGuy"; | |
githubId = 19699320; | |
}; | |
franzmondlichtmann = { | |
name = "Franz Schroepf"; | |
email = "franz-schroepf@t-online.de"; | |
github = "franzmondlichtmann"; | |
githubId = 105480088; | |
}; | |
srounce = { | |
name = "Samuel Rounce"; | |
email = "me@samuelrounce.co.uk"; | |
github = "srounce"; | |
githubId = 60792; | |
}; |
So, where should I put my entry?
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes