Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/contributing/quick-start: Replace dead thunderbird link #208868

Merged
merged 1 commit into from
Jan 4, 2023
Merged

doc/contributing/quick-start: Replace dead thunderbird link #208868

merged 1 commit into from
Jan 4, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 3, 2023

The thunderbird derivation is using buildMozillaMach these days, shared with Firefox and Librefox, so it is probably the correct , although more complicated, successor.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jan 3, 2023

Did you mean Librewolf?

@mweinelt
Copy link
Member Author

mweinelt commented Jan 3, 2023

Any weird animal will do.

@mweinelt
doc/contributing/quick-start: Replace dead thunderbird link
8b79bf0 
The thunderbird derivation is using `buildMozillaMach` these days,
shared with Firefox and Librefox, so it is probably the correct
, although more complicated, successor.
@aktaboot aktaboot mentioned this pull request Jan 3, 2023
Closed
3 tasks
@fricklerhandwerk fricklerhandwerk merged commit 895a4d1 into NixOS:master Jan 4, 2023
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Successfully created backport PR #208978 for release-22.11.

@mweinelt mweinelt deleted the quick-start-deadlink branch January 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @vcunat @fricklerhandwerk