nixos/installation-cd-minimal: include HTML doc #211053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we don't really need HTML documentation in the minimal installer, not including it may cause annoying cache misses in the case of the NixOS manual.
|
@ofborg test installer.simple |
|
Shouldn't you also revert a88a515? |
|
That issue seems to have a different cause, see #210966 (comment) |
pennae
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
3MB on the image sounds like a reasonable tradeoff. chances are very high that the manua is going to be downloaded at least anyway, so where we put it really doesn't matter that much. (and the iso squashfs is compressed, so we wouldn't save much traffic by downloading from cache either)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #210966 (comment). Inflates the image by ~3 MB (825 → 828).