Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bottles: 2022.12.14.1 -> 50.2 #211101

Merged
merged 1 commit into from Jan 21, 2023
Merged

bottles: 2022.12.14.1 -> 50.2 #211101

merged 1 commit into from Jan 21, 2023

Conversation

SuperSamus
Copy link
Contributor

@SuperSamus SuperSamus commented Jan 16, 2023 •
edited

Description of changes

https://github.com/bottlesdevs/Bottles/releases/tag/50
https://github.com/bottlesdevs/Bottles/releases/tag/50.1
https://github.com/bottlesdevs/Bottles/releases/tag/50.2

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSamus SuperSamus changed the title bottles: 2022.12.14.1 -> 50.1 bottles: 2022.12.14.1 -> 50.2 Jan 18, 2023
@SuperSamus
Copy link
Contributor Author

SuperSamus commented Jan 18, 2023 •
edited

(The tag was previously misplaced, that's why some checks failed. They should work if rerun)

@SuperSamus SuperSamus force-pushed the bottles-update branch 2 times, most recently from d5ff827 to e0d7bc6 Compare January 20, 2023 18:08
@SuperSamus SuperSamus mentioned this pull request Jan 20, 2023
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1738

@SuperSandro2000 SuperSandro2000 merged commit 11b0929 into NixOS:master Jan 21, 2023
@SuperSamus SuperSamus deleted the bottles-update branch January 21, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psydvl psydvl Awaiting requested review from psydvl

@SCOTT-HAMILTON SCOTT-HAMILTON Awaiting requested review from SCOTT-HAMILTON

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSamus @nixos-discourse @SuperSandro2000