Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.cython: 0.29.32 -> 0.29.33 #211703

Merged
merged 2 commits into from
Jan 22, 2023
Merged

python310Packages.cython: 0.29.32 -> 0.29.33 #211703

merged 2 commits into from
Jan 22, 2023

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 20, 2023 •
edited by fabaff

Description of changes

Fixes python311Packages.inflect. See cython/cython#5031.

Fixes #211343

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request Jan 20, 2023
Merged
13 tasks
@dotlambda dotlambda changed the base branch from master to staging January 20, 2023 02:52
@mweinelt mweinelt closed this Jan 20, 2023
@mweinelt mweinelt reopened this Jan 20, 2023
@dotlambda dotlambda closed this Jan 21, 2023
@dotlambda dotlambda reopened this Jan 21, 2023
This was referenced Jan 21, 2023
Merged
Merged
Merged
@dotlambda dotlambda requested a review from fabaff January 21, 2023 18:08
@dotlambda dotlambda merged commit 3fe688f into NixOS:staging Jan 22, 2023
@dotlambda dotlambda deleted the cython-0.29.33 branch January 22, 2023 14:31
@dotlambda
Copy link
Member Author

@vcunat Can we cherry-pick this to staging-next?

@vcunat
Copy link
Member

vcunat commented Jan 22, 2023 

$ ./maintainers/scripts/rebuild-amount.sh HEAD^^
  18178 x86_64-darwin
  32818 x86_64-linux

This is very large, and staging-next has roughly 50% binaries already. So I won't cherry-pick that, unless this is considered urgent (doesn't seem so to me at a quick glance).

This was referenced Feb 7, 2023
Closed
Closed
@superherointj superherointj mentioned this pull request Feb 9, 2023
Closed
13 tasks
@dotlambda dotlambda mentioned this pull request Feb 13, 2023
Closed
12 tasks
@NorfairKing
Copy link
Contributor

Could this be backported to nixos-22.11? It's causing this bug: cython/cython#4804

@NorfairKing
Copy link
Contributor

Gentle ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @vcunat @NorfairKing @mweinelt