Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-studio-plugins.obs-livesplit-one: init at 0.2.0 #212262

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

Bauke
Copy link
Member

@Bauke Bauke commented Jan 23, 2023

Description of changes

This adds obs-livesplit-one as an obs-studio-plugins package.

This is the first time I've ever really done anything with Nix besides tinkering with my configuration, so anything I should know would be most appreciated. I did a nixos-rebuild test and confirmed the plugin works for me with nixpkgs checked out to nixos-version --hash, so as far as I can tell I did it correctly.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the PR title and commit message to obs-studio-plugins.obs-livesplit-one: init at 0.2.0. This lets the CI test the changes.

I'll try out the plugin later.

@Bauke Bauke changed the title obs-livesplit-one: init at 0.2.0 obs-studio-plugins.obs-livesplit-one: init at 0.2.0 Jan 24, 2023
Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, works OK. The ofborg checks are still failing, I've added a suggestion that should fix that.

@raphaelr
Copy link
Contributor

@ofborg build obs-studio-plugins.obs-livesplit-one

@NickCao NickCao merged commit d30f226 into NixOS:master Jan 26, 2023
@Bauke Bauke deleted the add-obs-livesplit-one branch January 20, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants