Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rstudio add desktop file #21362

Merged
merged 2 commits into from
Dec 23, 2016
Merged

Rstudio add desktop file #21362

merged 2 commits into from
Dec 23, 2016

Conversation

lverns
Copy link
Contributor

@lverns lverns commented Dec 22, 2016

Motivation for this change

Adds a desktop file for RStudio to make it easier to launch in a graphical environment.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Needed since we want to access desktopItem from postInstall.
@mention-bot
Copy link

@lverns, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ehmry, @mucaho and @peti to be potential reviewers.

@peti peti merged commit 06f51e1 into NixOS:master Dec 23, 2016
@lverns lverns deleted the rstudio-add-desktop-file branch July 23, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants