remarshal: 0.3.0 -> 0.6.0 #21523
Merged
remarshal: 0.3.0 -> 0.6.0 #21523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @kamilchm, @pSub and @FRidh to be potential reviewers. |
FRidh
reviewed
Dec 30, 2016
| @@ -5868,7 +5868,7 @@ in { | |||
| sha256 = "1v9j9fmf8g911yg6k01xa2db6dx3wv73zkk7fncsj7vagjqgs20l"; | |||
| }; | |||
|
|
|||
| propagatedBuildInputs = with self; [ self.six ]; | |||
| propagatedBuildInputs = with self; [ six ]; | |||
There was a problem hiding this comment.
Please remove this unrelated change as it can cause trouble in the future with cherry-picking.
FRidh
reviewed
Dec 30, 2016
| checkPhase = "${python.interpreter} test/test.py"; | ||
|
|
||
| # fetchgit used to ensure test submodule is available | ||
| src = pkgs.fetchgit { |
There was a problem hiding this comment.
fetchFromGitHub retrieves the tarball. We need a proper git checkout in order to get the submodule.
There was a problem hiding this comment.
ah, its a git submodule. OK, then it makes sense :)
FRidh
approved these changes
Dec 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
remarshal: 0.3.0 -> 0.6.0
upstream rewrote the application in python.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)