Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.pyregion: skip failing tests #215426

Merged
merged 1 commit into from
Feb 15, 2023
Merged

python311Packages.pyregion: skip failing tests #215426

merged 1 commit into from
Feb 15, 2023

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Feb 9, 2023 •
edited
Loading

python311Packages.pyregion: skip failing tests

  • test_calculate_rotation_angle
  • test_region

Error logs:

(This package has shown as broken in my downstream builds. I have no domain knowledge here.)

Maybe of interest? Upstream is retiring package: astropy/pyregion#153

@ofborg ofborg bot requested a review from smaret February 9, 2023 04:26
smaret
smaret approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@smaret smaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@superherointj superherointj changed the base branch from staging to master February 14, 2023 21:40
@superherointj
Copy link
Contributor Author

Result of nixpkgs-review pr 215426 run on x86_64-linux 1

1 package failed to build:
  • python310Packages.spectral-cube
3 packages built:
  • python310Packages.aplpy
  • python310Packages.pyregion
  • python311Packages.pyregion

@smaret
Copy link
Member

smaret commented Feb 14, 2023

Result of nixpkgs-review pr 215426 run on x86_64-darwin 1

2 packages failed to build:
  • python310Packages.aplpy
  • python310Packages.spectral-cube
2 packages built:
  • python310Packages.pyregion
  • python311Packages.pyregion

@superherointj
Copy link
Contributor Author

superherointj commented Feb 14, 2023 •
edited
Loading

@smaret Did tests pass in Darwin for python310Packages.pyregion without skipping? (You could just checkout master and build there.)

@smaret
Copy link
Member

smaret commented Feb 14, 2023

@superherointj Yes, the tests in Darwin for both python310Packages.pyregion and python311Packages.pyregion. It would be better not to skip them on Darwin.

@superherointj
Copy link
Contributor Author

superherointj commented Feb 14, 2023 •
edited
Loading

@superherointj Yes, the tests in Darwin for both python310Packages.pyregion and python311Packages.pyregion. It would be better not to skip them on Darwin.

Answer was a bit confusing. Did the tests pass or fail in master for darwin? (just double checking)
But from your last sentence I suppose I should leave it as it is then.
Thanks for testing.

@ofborg ofborg bot requested a review from smaret February 14, 2023 22:45
@smaret
Copy link
Member

smaret commented Feb 15, 2023

@superherointj Sorry for the confusion. The tests do pass in master on Darwin, no need to skip them on this platform.

@superherointj
python311Packages.pyregion: skip 2 failing tests
e7d9119 
Skipping 2 tests because it's failing. Domain knowledge was unavailable on decision.
Error logs: https://gist.github.com/superherointj/3f616f784014eeb2e3039b0f4037e4e9
@ofborg ofborg bot requested a review from smaret February 15, 2023 14:55
@smaret
Copy link
Member

smaret commented Feb 15, 2023

Result of nixpkgs-review pr 215426 run on x86_64-darwin 1

1 package failed to build:
  • python310Packages.spectral-cube
3 packages built:
  • python310Packages.aplpy
  • python310Packages.pyregion
  • python311Packages.pyregion

@superherointj superherointj merged commit 777bc81 into NixOS:master Feb 15, 2023
@superherointj superherointj deleted the python311Packages.pyregion-skip-failing-tests branch February 15, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@smaret smaret smaret approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superherointj @smaret @fabaff @SuperSandro2000