New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No require file #2160
No require file #2160
Conversation
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
requireFile should not be used in nixpkgs
It depends on a package removed due to requireFile
Though I would be much in favor of this, in particular the removal of oraclejdk is going to make some people unhappy... We may want to consider creating a separate repository for these (say, "nix-warez"). |
+1 for that. Do you think it makes sense to put broken or WIP stuff in the same repo? I think a repo for "stuff with no expectation of anything working or being the right thing but still might be useful to share" in general would be nice. |
What's wrong with requireFile? I don't see removing packages as solution, i
|
So if i pass correct parameters to curl and hack the download of unfree
|
Also by removing cgminer we break nixos module we have.
|
The cgminer commit removed the module. @edolstra can speak better than I to the policy, but the point is not specifically about |
Cgimer is opensource, just amdapp-sdk isn't and it also builds without it.
|
No, it mostly is about However, if we hide unfree packages by default (#2134), this becomes less of an issue, since then the user explicit has to ask for it. |
Oh, OK. So if we had #2134 we could continue using |
@offlinehacker I didn't know about cgminer, if @edolstra still wants this after #2134 I'll fix it to just not depend on amdapp-sdk |
Ok i guess hiding unfree packages kinda makes sense. The problem is that
|
@shlevy thanks :)
|
-1. Removing requireFile and all software (required) to use it is not nice to our users (and that includes me). I hope we instead can set allowUnfree = false (like @edolstra suggests in #2134) to filter out these packages for people that don't want (to see) them. And still use requireFile when there is not other option. @shlevy: A repo for "stuff with no expectation of anything working or being the right thing but still might be useful to share" sounds like a contradiction to me ;-) |
@bjornfor Currently in nixpkgs we have works in progress, experiments, completely broken packages... More than we can hope to maintain with our current community. Of course we could just nuke them, but having them somewhere where people can refer to them if/when they have time without them polluting nixpkgs seems like an improvement, no? |
The |
@shlevy: I guess it's difficult to discuss this further while keeping it generic and not discussing specific packages / code. My personal opinion is still that a central repo for "work-in-progress, experiments, completely broken packages" is of little use and is better handled with traditional cooperation via git/github/mailing list (which does not require a central repo). But I don't really mind if such an experimental repo existed (I don't have to use it). What I mainly reacted to is the idea of moving all packages using requireFile out of nixpkgs and into a separate repo, because that'd make my life more difficult. Fortunately, it seems I don't have to worry about that[1]. If there are specific packages or experiments you would like to get rid of (slowing down your nixpkgs hacking), please send pull-requests for removal and let the nixos community decide. Btw, I'm curious of what specific things you would like to remove. Right now I can only think of broken packages, for which [1] http://lists.science.uu.nl/pipermail/nix-dev/2014-April/012916.html |
I'm not particularly fond of Is there a better way to support the use models of:
... and it should be possible to fix |
@edolstra Closing this under the assumption that the disabling of unfree by default means it's OK to add more |
According to @edolstra's comments on #2129,
requireFile
should not be used in nixpkgs. Merging this should wait for after14.04
as it removes some key packages.