Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildRustPackage: use frozen cargo fetches #22021

Closed
wants to merge 2 commits into from
Closed

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 21, 2017

cargo will not try to download anything from the web but will instead
return a clean error message stating which dependency is not up to date.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cargo will not try to download anything from the web but will instead
return a clean error message stating which dependency is not up to date.
@globin
Copy link
Member

globin commented Jan 22, 2017

I tried this with an updated registry from just a few minutes ago and heatseeker (which fails on travis) and have the same failure, but builds without this PR applied.

@Mic92 Mic92 mentioned this pull request Jan 22, 2017
@Mic92
Copy link
Member Author

Mic92 commented Jan 22, 2017

Fixed by upgrading heatseeker. The dependencies were not properly locked before.

@globin
Copy link
Member

globin commented Jan 22, 2017

More failures on Travis please run nox-review especially for PRs like this one.

@Mic92
Copy link
Member Author

Mic92 commented Jan 22, 2017

yes, working on it.

@Mic92
Copy link
Member Author

Mic92 commented Jan 22, 2017

too, much broken packages I don't want to fix now.

@Mic92 Mic92 closed this Jan 22, 2017
@Mic92 Mic92 deleted the cargo branch September 6, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants