nixos/tests/installer.nix: fix hydra eval #220308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydra Eval has been throwing these eval errors for the past four months, which makes the yellow "Eval Errors" bubble pretty useless: https://hydra.nixos.org/eval/1790611#tabs-errors ``` in job ‘nixos.tests.installer.separateBoot.aarch64-linux’: error: Non-EFI boot methods are only supported on i686 / x86_64 in job ‘nixos.tests.installer.simple.aarch64-linux’: error: Non-EFI boot methods are only supported on i686 / x86_64 in job ‘nixos.tests.installer.lvm.aarch64-linux’: error: Non-EFI boot methods are only supported on i686 / x86_64 ``` This PR moves the failure for the `!isEfi && !pkgs.stdenv.hostPlatform.isx86` case from eval-time to runtime, so the failure gets categorized under the test that produced it, rather than just being lumped in to the catch-all Eval Errors pile which... apparently nobody cares about.
ghost
mentioned this pull request
|
Yes but that's not at fault. Everything was fine until four months ago. The problem is that Hydra shouldn't even be attempting to eval this job on aarch64. Unfortunately debugging the Hydra-related parts of nixpkgs basically requires setting up your own Hydra instance, since Hydra expects to have access to the Nix evaluator (rather than just the resulting derivations). |
Aha. I wonder if it's related to addition of aarch64 to the CI. I see that Otheriwse it should be fine to turn the test into no-op. |
trofi
approved these changes
Mar 10, 2023
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Hydra Eval has been throwing these eval errors for the past four months, which makes the yellow "Eval Errors" bubble pretty useless:
https://hydra.nixos.org/eval/1790611#tabs-errors
This PR moves the failure for the
!isEfi && !pkgs.stdenv.hostPlatform.isx86case from eval-time to runtime, so the failure gets categorized under the test that produced it, rather than just being lumped in to the catch-all Eval Errors pile which...Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)