Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio-plugins.obs-teleport: init at 0.6.5 #223953

Merged
merged 1 commit into from
Apr 27, 2023
Merged

obs-studio-plugins.obs-teleport: init at 0.6.5 #223953

merged 1 commit into from
Apr 27, 2023

Conversation

paveloom
Copy link
Member

https://github.com/fzwoch/obs-teleport

Closes #223775.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Krutonium
Copy link
Contributor

Oooo! Thank you! :D

Krutonium
Krutonium reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@Krutonium Krutonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krutonium
Copy link
Contributor

Krutonium commented Apr 2, 2023 •
edited

So a random thought I just had; Would it be possible to have an openFirewall option in this? There's no predefined port but one can specify one, and you need to open the firewall for it to work.

FWIW I have been using this for a couple days and it's working flawlessly.
image

@paveloom
Copy link
Member Author

paveloom commented Apr 2, 2023

So a random thought I just had; Would it be possible to have an openFirewall option in this? There's no predefined port but one can specify one, and you need to open the firewall for it to work.

The openFirewall and port options are usually provided in a NixOS module, not a package. I think you can use the standard firewall module to punch a hole for this specific program.

@Krutonium
Copy link
Contributor

...You're absolutely correct.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/922

@SuperSandro2000 SuperSandro2000 merged commit a735718 into NixOS:master Apr 27, 2023
@paveloom paveloom deleted the obs-teleport branch April 28, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krutonium Krutonium Krutonium approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: obs-teleport
4 participants
@paveloom @Krutonium @nixos-discourse @SuperSandro2000