souper: init at 2017-01-05 #22468
souper: init at 2017-01-05 #22468
Conversation
| }; | ||
|
|
||
| buildInputs = [ | ||
| cmake |
There was a problem hiding this comment.
cmake and makeWrapper are nativeBuildInputs.
There was a problem hiding this comment.
Excellent point, as a person who has worked heavily on Nix cross-compilation to Windows I really should have remembered that fact.
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A superoptimizer for LLVM IR"; | ||
| homepage = "https://github.com/google/souper"; |
There was a problem hiding this comment.
Nitpick: You don't need quotes around URLs.
There was a problem hiding this comment.
URL literals complicate parsing for very little benefit (see this issue for more details), so I wouldn't be surprised if they were deprecated in the future.
There was a problem hiding this comment.
I wasn't are of this issue. Thank you!
There was a problem hiding this comment.
Eelco seems to be against deprecating them, so it's unlikely to happen fully. (It might happen for non-URL URIs.)
Motivation for this change
souperis an LLVM-based superoptimization tool.Things done
(nix.useSandbox on NixOS, or option
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)