souper: 2017-03-07 -> 2017.03.23

[dtzWill]

• update to latest
• change version format for nix-env friendliness.

Motivation for this change

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[mention-bot]

@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @taktoa to be a potential reviewer.

[taktoa]

This is giving me deja vu. I feel like I had a debate with a reviewer on the PR that added this in which I set the version to 20170307 and he wanted the hyphens in there.

[dtzWill]

Input welcome! It seems familiar to me as well, hopefully this can be agreed on quickly :).

Don't see any mention of it in the PR that was first merged with Souper, though: #22468

(I bounced through the CONTRIBUTORS.md before submitting because I recall there being some rule/standard/suggestion but I can't find it now...)

[rycee]

Hmm, why is 2017.03.23 more nix-env friendly? Also https://nixos.org/nixpkgs/manual/#sec-package-naming

[dtzWill]

Darn, sorry I couldn't find that document. Knew it existing somewhere.

Will drop the version change portion.

The "more nix-env friendly" claim seems to be at least partially untrue: apparently it's the shell completion that doesn't work nicely with the hyphenated dates as version strings. I have no evidence nix-env itself handles dots and differently than hyphens, my mistake.

[dtzWill]

Closing in favor of #25687, sorry folks.

[rycee]

For future reference, there is no problem force pushing revised commits in a pull request branch. Just also make a comment saying that you did a force push as it is easy to miss for people watching the PR ☺

[dtzWill]

Looking at how nix handles versions further confirms the two are handled equivalently for at least this case: https://github.com/NixOS/nix/blob/795d9b866881871419651081eb112f23b2f5bff5/src/libexpr/names.cc#L44

And regarding force-push, you got it 👍.

[rycee]

Yeah, you can double confirm this using nix-repl:

nix-repl> builtins.parseDrvName "foo-bar-2017-03-23"
{ name = "foo-bar"; version = "2017-03-23"; }

nix-repl> builtins.parseDrvName "foo-bar-a2017-03-23"
{ name = "foo-bar-a2017"; version = "03-23"; }

nix-repl> builtins.compareVersions "2017-03-07" "2017-03-23"
-1

nix-repl> builtins.compareVersions "2017-03-07" "2017-03-07"
0

nix-repl>